From: Jonas Ådahl <jadahl@gmail.com>
Date: Wed, 17 Aug 2022 13:53:45 +0000 (+0200)
Subject: calendar: Unbind settings when destroying
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~405^2^2~240
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=fa47a7576d8bef93b95715165837ce9eee7d75fa;p=gnome-shell.git

calendar: Unbind settings when destroying

Running dispose on the setting causes issues when we're being destroyed,
as the signal handler in the GSettings binding will be cleared by the
GObject itself before it has the chance, resulting in warnings.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1349>
---

diff --git a/js/ui/calendar.js b/js/ui/calendar.js
index 84bdaeea8..985153663 100644
--- a/js/ui/calendar.js
+++ b/js/ui/calendar.js
@@ -908,7 +908,7 @@ class DoNotDisturbSwitch extends PopupMenu.Switch {
             Gio.SettingsBindFlags.INVERT_BOOLEAN);
 
         this.connect('destroy', () => {
-            this._settings.run_dispose();
+            Gio.Settings.unbind(this, 'state');
             this._settings = null;
         });
     }